Log of the #fcrepo channel on chat.freenode.net

Using timezone: Eastern Standard Time
* bryjbrown joins07:01
* bryjbrown leaves07:09
* bryjbrown joins07:21
* bryjbrown leaves08:16
* awoods joins08:25
* dwilcox joins08:50
* benpennell joins09:00
* whikloj joins
* dhlamb joins09:07
* apb18 joins09:09
* dwilcox leaves09:26
* dwilcox_ joins
* bryjbrown joins09:32
<awoods>apb18/whikloj: Are one of you available for a quick review/merge of: https://github.com/fcrepo4-exts/fcrepo-audit/pull/4709:46
* bryjbrown leaves09:48
<whikloj>awoods: Does it need testing? It appears simple enough, but I'm not super familiar with the changes to Messaging
<apb18>awoods: What difference in observable behaviour should I be looking for?09:49
<awoods>whikloj: The unit tests are currently failing: https://github.com/fcrepo4-exts/fcrepo-audit
whikloj/apb18: when inspecting messages, you should see activity-streams namespaces instead of fedora ones.09:51
whikloj/apb18: This just fixes the impact of the changes that went into: https://jira.duraspace.org/browse/FCREPO-2602
<apb18>I need to drop a car off at the mechanic, but when get back, can see about deploying it with audit, attaching the listener, and looking at the messages09:53
* bryjbrown joins09:57
<whikloj>awoods: sorry just wanted to finish up my work on fcrepo-2623 before stashing it, what do you mean the unit tests are failing? Are we ignoring them now? Because Travis seems happy10:22
* awoods on a call10:24
travis is unhappy here ^^
on master
see the badge
* bseeger joins10:25
* github-ff joins11:04
[fcrepo-audit] whikloj closed pull request #47: Update to use ActivityStreams (master...fcrepo-2602) https://git.io/vdN0z
* github-ff leaves
* ruebot joins11:09
* ruebot leaves11:10
* travis-ci joins
fcrepo4-exts/fcrepo-audit#176 (master - fba6cae : Jared Whiklo): The build was fixed.
Change view : https://github.com/fcrepo4-exts/fcrepo-audit/compare/b5c85dc76674...fba6cae26517
Build details : https://travis-ci.org/fcrepo4-exts/fcrepo-audit/builds/292128006
* travis-ci leaves
* bryjbrown leaves11:15
<whikloj>awoods: I think the failing tests was just a Travis hiccup11:17
<awoods>whikloj: the build was failing for me locally as well
<whikloj>awoods: ok, did you fix the tests then? Because it built for me with no trouble
<awoods>whikloj: fcrepo-audit built for you before the PR?11:18
<whikloj>awoods: ummm no after, I didn't try before. But you didn't change any tests in your PR
awoods: Ohhhh was the issue that audit needed to switch to ActivityStreams?11:19
<awoods>whikloj: I changed the predicates that were then used in the tests... but since they had the same name, the test did not change directly.
* mcritchlow joins11:28
* mcritchlow leaves11:36
* peichman joins11:40
* peichman leaves11:52
* apb18 leaves12:02
* bryjbrown joins12:16
* dwilcox_ leaves12:27
* bryjbrown leaves13:07
* bryjbrown joins
* bseeger leaves13:19
* dwilcox joins13:45
* bseeger joins13:50
* peichman joins14:32
* peichman leaves14:41
* peichman joins14:43
* peichman leaves
* whikloj leaves14:59
* bseeger leaves15:25
* peichman joins15:27
* bryjbrown leaves15:39
* peichman leaves15:49
* dwilcox leaves15:57
* dwilcox joins16:30
* dwilcox leaves17:16
* benpennell leaves17:20
* dwilcox joins17:41
* peichman joins17:51
* peichman leaves17:52
* dwilcox leaves17:56
* dwilcox joins17:57
* dhlamb leaves
* dwilcox leaves18:09
* peichman joins19:37
* peichman leaves20:53
* yamil__ joins20:56
* yamil_ leaves20:58
* peichman joins
* jonathangee leaves
* peichman leaves20:59
* peichman joins
* jonathangee joins21:02
* peichman leaves21:04
* peichman joins21:47
* peichman leaves21:54
* benpennell joins22:32
* peichman joins22:38
* peichman leaves22:42
* github-ff joins22:46
[fcrepo4] whikloj closed pull request #1263: Add TimeMap headers and HttpResource converter (memento-versioning...fcrepo-2623) https://git.io/vdpxl
* github-ff leaves
* benpennell leaves23:27
* benpennell joins23:28
* benpennell leaves23:30
* peichman joins00:26
* peichman leaves00:30
* peichman joins01:03
* peichman leaves01:08