Log of the #fcrepo channel on chat.freenode.net

Using timezone: Eastern Standard Time
* ksclarke leaves00:56
* awead joins08:56
* dwilcox joins08:57
* mhwood joins09:01
* dhlamb joins09:06
* awead leaves09:21
* ajs6f joins09:22
* awoods joins09:32
* awead joins09:34
* awead leaves09:37
* osmandin joins09:42
* awead joins09:45
* awead leaves09:52
* ksclarke joins09:57
* awead joins10:00
<f4jenkins>Yippee, build fixed!10:53
Project fcrepo4-T2 build #269: FIXED in 4 min 59 sec: http://jenkins.fcrepo.org/job/fcrepo4-T2/269/
* osmandin leaves11:56
* whikloj joins12:30
* acoburn joins
* awead leaves12:32
<awoods>ajs6f: I see that yinlin just merged your PR: https://github.com/yinlinchen/fcrepo4/pull/513:11
* mhwood leaves
<awoods>ajs6f: You probably saw my comment the just preceded the merge. Thoughts?13:12
ajs6f: You probably saw my comment that just preceded the merge. Thoughts?
* awead joins13:38
* osmandin joins13:41
<ajs6f> awoods: Try it and see if my new tests still pass.13:45
* dhlamb leaves14:10
* dshalvi joins14:52
* awead leaves14:58
* osmandin leaves
* dwilcox leaves14:59
* awead joins
* dwilcox joins15:01
* dwilcox leaves
<awoods>ajs6f: I suspect the tests will pass... but there is a checkstyle error that stops the build. https://travis-ci.org/fcrepo4/fcrepo4/builds/6709317915:03
<ajs6f>home/travis/build/fcrepo4/fcrepo4/fcrepo-kernel/src/main/java/org/fcrepo/kernel/utils/UncheckedPredicate.java:29:5: unexpected token: default
/home/travis/build/fcrepo4/fcrepo4/fcrepo-kernel/src/main/java/org/fcrepo/kernel/utils/UncheckedPredicate.java:29:32: unexpected token: T
[INFO] Starting audit...
/home/travis/build/fcrepo4/fcrepo4/fcrepo-kernel/src/main/java/org/fcrepo/kernel/utils/UncheckedPredicate.java:32:9: Got an exception - expecting EOF, found '}'
unexpected token: default means it's confused by Java 8 default impls in interfaces. I don't know what to do about that.15:04
* github-ff joins15:22
[fcrepo-camel] acoburn opened pull request #74: support for fixity checking (master...fcrepo-1587) http://git.io/vL4Lu
* github-ff leaves
* dwilcox joins15:28
* ajs6f leaves15:36
* ajs6f joins
awoods: You can try pulling out that class and see if reverting yinlin's commit that pulled out JCR_UUID will work.15:39
<awoods>ajs6f: ok, I will give it a look.15:40
<ajs6f>awoods: I think we will want UncheckedPredicate and its kin from the Java 8 branch, because otherwise you get into a nightmare of try-catch stuff. But Checkstyles is really just bogged down, it seems.
<awoods>ajs6f: I wonder if we can use the most up to date checkstyle fixes: https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html15:43
<acoburn>awoods: I recently updated the checkstyle plugin to 2.15, which (I believe) is the latest version15:45
<awoods>acoburn: you will see in the link above that the plugin version 2.15 uses the 6.1.1 version of the checkstyle library. However, you can upgrade the checkstyle library in the maven configuration.15:46
<acoburn>awoods: I see. 6.7 != 6.1.115:48
<awoods>acoburn: then the question becomes, "Does 6.7 support the 'default' keyword"?
* github-ff joins15:49
[fcrepo-camel] awoods pushed 2 new commits to master: http://git.io/vL4nJ
fcrepo-camel/master cad5f3d Aaron Coburn: support for fixity checking
fcrepo-camel/master 8b80e37 Andrew Woods: Merge pull request #74 from acoburn/fcrepo-1587...
* github-ff leaves
* dwilcox leaves15:55
* github-ff joins16:03
[fcrepo4-client] awoods pushed 1 new commit to master: http://git.io/vL4lx
fcrepo4-client/master 0375aec Mike Durbin: Add support for creation of resources with repository-supplied paths....
* github-ff leaves
* github-ff joins16:04
[fcrepo4-client] awoods closed pull request #23: Added support for creation of resources with repository-supplied paths. (master...FCREPO-1588) http://git.io/vL3MM
* github-ff leaves
<acoburn>awoods: using ajs6f's branch, if I add an explicit dependency on com.puppycrawl.tools/checkstyle/6.1.1 in the checkstyle plugin, the error w/r/t default goes away16:07
awoods: the new error relates to a missing javadoc comment, but that seems easier to fix
<ajs6f>acoburn: Missing Javadoc is probably a genuine screwup from me.16:08
What is the PR this is about?
<awoods>acoburn: could you pass along your changes (as a PR against ajs6f's branch or otherwise)?
<acoburn>this is the HelpYinlin branch16:09
<ajs6f>awoods: I thought you said my branch was already merged into Yinlin's branch?
<awoods>ajs6f: Yinlin merged the PR that you made against his branch, yes.
<ajs6f>awoods: So shouldn't acoburn work a PR against _that_ branch?16:10
<acoburn>awoods/ajs6f: yes, I'll send a PR to Yinlin's branch
<awoods>ajs6f: The work in Yinlin's branch makes me a little nervous (ripping out tests). Are you ok with it?16:12
<ajs6f>awoods: That's why I added back in some new tests. The tests he removed were good to go— they were checking for the presence of UUIDs, which is exactly what we don't want. The ones I added check for the _absence_ of UUIDs, which is what we want.16:13
awoods: It could use more review to make sure he did it right, but let's get a build first.
<awoods>ajs6f: Thanks. I am glad to know you were coming from the same perspective.16:14
<ajs6f>awoods: I am not coming from the same perspective. My perspective isn't even reliably sane or human.16:15
Make no assumptions.
* ajs6f leaves16:19
* dshalvi leaves17:10
<acoburn>awoods: I sent a PR to Yinlin. A big part of the issue is that his branch needs to be rebased with the latest changes from the upstream repo17:12
awoods: that is to say, version 2.15 of the checkstyle plugin is just fine w/r/t ajs6f's code (Yinlin's branch uses 2.14)17:15
* dwilcox joins17:28
<awoods>thanks, acoburn.17:49
* github-ff joins17:52
[migration-utils] jwestgard opened pull request #26: Update README.md (master...patch-1) http://git.io/vLBfs
* github-ff leaves
* dwilcox leaves17:54
* github-ff joins17:56
[migration-utils] awoods pushed 2 new commits to master: http://git.io/vLBJh
migration-utils/master cdcf6e0 Joshua Westgard: Update README.md...
migration-utils/master 057dadd Andrew Woods: Merge pull request #26 from jwestgard/patch-1...
* github-ff leaves
* acoburn leaves17:58
* whikloj leaves17:59
* dwilcox joins18:20
* ksclarke leaves18:46
* dwilcox leaves18:58
* dwilcox joins
* dwilcox leaves18:59
* awead leaves19:46
* dwilcox joins20:35
* awead joins20:43
* ksclarke joins20:55
* ksclarke leaves21:02
* dwilcox leaves21:08
* ksclarke joins21:17
* ksclarke leaves21:22
* ksclarke joins21:36
* awead leaves23:06
* ff_logger__ joins23:29
* ff_logger leaves23:42
* ff_logger leaves23:47
* ff_logger joins00:02
* ksclarke leaves00:06
* ff_logger__ joins00:08

Generated by Sualtam