Log of the #duraspace-ff channel on chat.freenode.net

Using timezone: Eastern Standard Time
* Guest50254 leaves00:40
* pivotal-bot__ leaves04:12
* pivotal-bot__ joins04:13
* terrellt leaves04:16
* terrellt joins04:17
* pivotal-bot__ leaves04:18
* pivotal-bot__ joins
* terrellt leaves05:01
* terrellt joins05:02
* acoburn joins08:37
* dhlamb joins
* jgpawletko joins08:56
* ksclarke joins09:21
* Guest27181 leaves09:29
* Guest27181 joins
* ajs6f joins09:33
<awoods>acoburn/ajs6f: Would each of you please take one of the following completed tickets; review and merge it into master?09:37
https://jira.duraspace.org/browse/FCREPO-1496
https://jira.duraspace.org/browse/FCREPO-1487
Thanks!
<acoburn>awoods: sure, in a few minutes…09:38
<ajs6f>awoods: I already reviewed FCREPO-148709:39
<awoods>ajs6f: Great! please merge it to master.
<ajs6f>k09:40
* github-ff joins
[fcrepo4] ajs6f pushed 4 new commits to master: http://git.io/vfHoq
fcrepo4/master de826b2 Andrew Woods: Lessen leakage of JCR dependent code that extends beyond the kernel....
fcrepo4/master 7cb2a1c Andrew Woods: Updates based on code review...
fcrepo4/master c35f399 Andrew Woods: Add TODO to FedoraEvent for later clean-up.
* github-ff leaves
* travis-ci joins09:54
fcrepo4/fcrepo4#3633 (master - b379030 : A. Soroka): The build passed.
Change view : https://github.com/fcrepo4/fcrepo4/compare/02e56c8e3391...b3790309ba68
Build details : http://travis-ci.org/fcrepo4/fcrepo4/builds/60219003
* travis-ci leaves
<f4jenkins>Project fcrepo-audit build #12: FAILURE in 14 sec: http://jenkins.fcrepo.org/job/fcrepo-audit/12/09:56
<awoods>I am going to be offline for most of today and then for the rest of the week. If possible, it would be great if we could wrap up the Audit Service and make progress on the Blank Node issue. Send me an email if I can help move the processes forward.09:58
<acoburn>awoods: time for a quick question before you go?10:02
<awoods>acoburn: hit it
<acoburn>ajs6f might also have some insight10:03
<f4jenkins>Project fcrepo-message-consumer build #1153: UNSTABLE in 6 min 12 sec: http://jenkins.fcrepo.org/job/fcrepo-message-consumer/1153/
<acoburn>the issue is that some of the fcrepo-modules export packages from the org.modeshape namespace
this is not good for OSGi
<ajs6f>acoburn: That's morally wrong.
<acoburn>this involves fcrepo-kernel-impl and fcrepo-connector-file
<ajs6f>acouburn: Is that because we are leaking JCR stuff via our API?
<acoburn>I have no idea. I am not familiar with the code there10:04
either way, my sense is that it should be fixed
but I don't know why it's there in the first place
<ajs6f>acoburn: How are the exports being generated? Yes, it should be fixed, but that will be a _MASSIVE_ amount off work.
acoburn: I expect it's happening because Fedora types have method signatures with JCR types in them.10:05
E.g. FedoraResource.getNode().
<acoburn>https://github.com/fcrepo4/fcrepo4/tree/master/fcrepo-connector-file/src/main/java/org
and https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-connector-file/src/main/java/org/modeshape/connector/filesystem/ExternalJsonSidecarExtraPropertyStore.java
in fcrepo-kernel-impl: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-kernel-impl/src/main/java/org/modeshape/jcr/IsExternal.java10:06
that last one is used by fcrepo-jms (and possibly others)
<ajs6f>Oh, it's happening because we actually _put_ types into that package.
<acoburn>if it is necessary to redefine certain modeshape classes, I don't see how that is a big problem, but we can't export those10:07
that is, couldn't we just wrap that in an o.f.k.impl class?
<ajs6f>It is a problem in the sense that we need to get to MODE with that material and have a conversation with them about why we're doing that. It may have something to do with their funkadelic "injection framework".
<awoods>acoburn/ajs6f: I think it has to do with the fact that some other Mode's classes have protected members that we are able to hack into by creating our own classes in that same package namespace.10:08
<ajs6f>awoods: Have we talked to MODE about why need to do that and if they cold provide a better way?10:09
<acoburn>I see, but at least we shouldn't export those "hacks"
<awoods>ajs6f: no
<ajs6f>I nominate acoburn to start that conversation, because he hasn't hung out with the MODE people yet.
<awoods>acoburn: right. Is this a functional problem that you are running into? or a moral one?
<acoburn>functional
the OSGi bundle mechanism is generating "split packages"10:10
which is bad
<awoods>acoburn: in the meantime, can you just suppress those export statements in the manifest?10:11
<acoburn>no, because other modules rely on those exported packages!
that's why I'm suggesting wrapping those overridden classes in org.fcrepo classes and exporting those
<ajs6f>acoburn: That would not work. as awoods explained, we 're doing that speciicially to break package boundaries.10:12
* github-ff joins10:13
[fcrepo-audit] awoods pushed 1 new commit to master: http://git.io/vfH5w
fcrepo-audit/master 7edad2b Andrew Woods: Remove unthrown exception...
* github-ff leaves
<acoburn>so the only solution is to ask/wait for changes from the org.modeshape packages?10:14
<f4jenkins>Yippee, build fixed!
Project fcrepo-audit build #13: FIXED in 1 min 2 sec: http://jenkins.fcrepo.org/job/fcrepo-audit/13/
awoods: Remove unthrown exception
<ajs6f>acoburn: Getting changes from those packages sounds like the lasting solution.10:17
<f4jenkins>Yippee, build fixed!10:18
Project fcrepo-camel-toolbox build #54: FIXED in 3 min 25 sec: http://jenkins.fcrepo.org/job/fcrepo-camel-toolbox/54/
<awoods>I'm out... but will be popping my head up in a few hours.10:20
* travis-ci joins
fcrepo4-labs/fcrepo-audit#12 (master - 7edad2b : Andrew Woods): The build passed.
Change view : https://github.com/fcrepo4-labs/fcrepo-audit/compare/24edb8cd2526...7edad2bb3d52
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-audit/builds/60223645
* travis-ci leaves
<f4jenkins>Yippee, build fixed!10:53
Project fcrepo4-T2 build #218: FIXED in 5 min 2 sec: http://jenkins.fcrepo.org/job/fcrepo4-T2/218/
* awoods: Lessen leakage of JCR dependent code that extends beyond the kernel.
* awoods: Updates based on code review
* awoods: Add TODO to FedoraEvent for later clean-up.
* github-ff joins10:55
[fcrepo-camel-toolbox] escowles created suppress-internal-audit (+1 new commit): http://git.io/vfQLu
fcrepo-camel-toolbox/suppress-internal-audit 5fe0ddd Esmé Cowles: Adding check to suppress events about internal audit nodes
* github-ff leaves
* github-ff joins10:59
[fcrepo-camel-toolbox] escowles pushed 1 new commit to suppress-internal-audit: http://git.io/vfQmt
fcrepo-camel-toolbox/suppress-internal-audit a8f9d91 Esmé Cowles: Fixing audit.container interpolation
* github-ff leaves
* github-ff joins11:00
[fcrepo-camel-toolbox] escowles opened pull request #18: Suppress events about internal audit nodes (master...suppress-internal-audit) http://git.io/vfQm2
* github-ff leaves
* travis-ci joins
fcrepo4-labs/fcrepo-camel-toolbox#49 (suppress-internal-audit - 5fe0ddd : Esmé Cowles): The build failed.
Change view : https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/commit/5fe0ddd8dd24
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-camel-toolbox/builds/60229784
* travis-ci leaves
* travis-ci joins11:06
fcrepo4-labs/fcrepo-camel-toolbox#50 (suppress-internal-audit - a8f9d91 : Esmé Cowles): The build passed.
Change view : https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/compare/5fe0ddd8dd24...a8f9d9144a34
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-camel-toolbox/builds/60230527
* travis-ci leaves
* whikloj joins12:08
* ajs6f leaves12:12
* acoburn leaves12:39
* github-ff joins12:50
[fcrepo-camel-toolbox] escowles pushed 1 new commit to suppress-internal-audit: http://git.io/vf7Ig
fcrepo-camel-toolbox/suppress-internal-audit 1266e95 Esmé Cowles: Using filter() and correctly handling other containers that start with /audit
* github-ff leaves
* travis-ci joins12:55
fcrepo4-labs/fcrepo-camel-toolbox#52 (suppress-internal-audit - 1266e95 : Esmé Cowles): The build passed.
Change view : https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/compare/a8f9d9144a34...1266e95e8e8d
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-camel-toolbox/builds/60245872
* travis-ci leaves
* pgwillia joins13:31
* acoburn joins14:30
* acoburn leaves14:56
* acoburn joins14:58
* github-ff joins14:59
[fcrepo-camel-toolbox] acoburn pushed 2 new commits to master: http://git.io/vf5mi
fcrepo-camel-toolbox/master 6537082 Esmé Cowles: Merge pull request #18 from suppress-internal-audit...
fcrepo-camel-toolbox/master 5c7912a Aaron Coburn: Merge branch 'suppress-internal-audit'
* github-ff leaves
* github-ff joins15:00
[fcrepo-camel-toolbox] acoburn closed pull request #18: Suppress events about internal audit nodes (master...suppress-internal-audit) http://git.io/vfQm2
* github-ff leaves
* github-ff joins15:04
[fcrepo-audit] escowles created fcrepo-1481 (+2 new commits): http://git.io/vf5Oh
fcrepo-audit/fcrepo-1481 499ef00 Aaron Coburn: added test gear for fcrepo integration testing
fcrepo-audit/fcrepo-1481 2ef1a19 Esmé Cowles: Adding basic IT
* github-ff leaves
<f4jenkins>Project fcrepo-camel-toolbox build #59: FAILURE in 1 min 3 sec: http://jenkins.fcrepo.org/job/fcrepo-camel-toolbox/59/15:06
* travis-ci joins15:07
fcrepo4-labs/fcrepo-camel-toolbox#54 (master - 5c7912a : Aaron Coburn): The build passed.
Change view : https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/compare/ae8d4c20a88e...5c7912a47101
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-camel-toolbox/builds/60264033
* travis-ci leaves
* github-ff joins15:09
[fcrepo-audit] escowles force-pushed fcrepo-1481 from 2ef1a19 to 4790baf: http://git.io/vf5s1
fcrepo-audit/fcrepo-1481 4790baf Esmé Cowles: Adding basic IT
* github-ff leaves
* travis-ci joins15:14
fcrepo4-labs/fcrepo-audit#13 (fcrepo-1481 - 2ef1a19 : Esmé Cowles): The build passed.
Change view : https://github.com/fcrepo4-labs/fcrepo-audit/compare/499ef0016370^...2ef1a19668df
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-audit/builds/60264821
* travis-ci leaves
<f4jenkins>Yippee, build fixed!
Project fcrepo-camel-toolbox build #60: FIXED in 3 min 8 sec: http://jenkins.fcrepo.org/job/fcrepo-camel-toolbox/60/
* travis-ci joins15:17
fcrepo4-labs/fcrepo-audit#14 (fcrepo-1481 - 4790baf : Esmé Cowles): The build has errored.
Change view : https://github.com/fcrepo4-labs/fcrepo-audit/compare/2ef1a19668df...4790baf0c8d8
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-audit/builds/60265555
* travis-ci leaves
* github-ff joins15:19
[fcrepo-camel] adolski opened pull request #67: Fix the Spring DSL example in the readme (master...master) http://git.io/vf5c7
* github-ff leaves
* pgwillia_ joins15:32
* pgwillia leaves15:35
* github-ff joins15:53
[fcrepo-camel] acoburn closed pull request #67: Fix the Spring DSL example in the readme (master...master) http://git.io/vf5c7
* github-ff leaves
* dhlamb leaves15:56
* travis-ci joins15:57
fcrepo4/fcrepo-camel#162 (master - 0915907 : Aaron Coburn): The build passed.
Change view : https://github.com/fcrepo4/fcrepo-camel/compare/80b7a9f8450b...091590782e9c
Build details : http://travis-ci.org/fcrepo4/fcrepo-camel/builds/60271255
* travis-ci leaves
* github-ff joins16:40
[fcrepo-camel-toolbox] awoods deleted suppress-internal-audit at 1266e95: http://git.io/vf577
* github-ff leaves
<f4jenkins>Project fcrepo-camel-toolbox build #62: UNSTABLE in 3 min 9 sec: http://jenkins.fcrepo.org/job/fcrepo-camel-toolbox/62/16:43
* fcrepo-bot joins
* github-ff joins17:09
[fcrepo-camel-toolbox] awoods force-pushed fcrepo-camel-toolbox-4.1.1-audit.1 from 8abe285 to 7188427: http://git.io/vfMQE
* github-ff leaves
<f4jenkins>Yippee, build fixed!17:12
Project fcrepo-camel-toolbox build #63: FIXED in 3 min 16 sec: http://jenkins.fcrepo.org/job/fcrepo-camel-toolbox/63/
* travis-ci joins17:18
fcrepo4-labs/fcrepo-camel-toolbox#55 (fcrepo-camel-toolbox-4.1.1-audit.1 - 5c7912a : Aaron Coburn): The build passed.17:19
Change view : https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/compare/8abe285247cb...7188427500c2
Build details : http://travis-ci.org/fcrepo4-labs/fcrepo-camel-toolbox/builds/60282398
* travis-ci leaves
* pgwillia leaves17:29
* acoburn leaves17:35
* fcrepo-bot leaves17:45
* whikloj leaves17:54
* jgpawletko leaves18:00
* awoods leaves19:16
* ksclarke leaves19:34
* ksclarke joins20:58
* Guest97006 leaves21:02
* ksclarke joins21:57

Generated by Sualtam