Log of the #duraspace-ff channel on chat.freenode.net

Using timezone: Eastern Standard Time
* ksclarke leaves01:26
* bljenkins leaves03:15
* bljenkins joins
* dwilcox joins07:36
* mohamed joins08:36
* mohamed1 joins
* mohamed leaves
* gregjansen joins09:09
* tecoripa joins09:53
* tecoripa leaves
* github-ff joins09:57
[fcrepo4-client] escowles opened pull request #9: Content implementation, making triple-parsing functionality shareable (master...content-impl) http://git.io/yWivVw
* github-ff leaves
<pivotal-bot>Esme Cowles added comment: "https://github.com/fcrepo4-labs/fcrepo4-client/pull/9 (depends on PR #8, see #77109350)" https://www.pivotaltracker.com/story/show/7505329809:58
Esme Cowles finished "Binary content resource impl" https://www.pivotaltracker.com/story/show/75053298
* ksclarke joins10:06
* ksclarke leaves
* ksclarke joins
<cbeer>awoods: escowles' fix for https://www.pivotaltracker.com/story/show/77492702 fixes my immediate issue.10:56
<pivotal-bot>bug: OutOfMemoryError (running out of threads) after many updates (delivered) / owner: Esme Cowles
<awoods>thanks, cbeer.10:57
<pivotal-bot>Andrew Woods accepted "OutOfMemoryError (running out of threads) after many updates" https://www.pivotaltracker.com/story/show/77492702
* scossu joins11:01
<pivotal-bot>Giulia HILL started "Acceptance test: Large files" https://www.pivotaltracker.com/story/show/7711249011:02
* Giulia joins11:03
* github-ff joins11:37
[fcrepo4-client] awoods pushed 2 new commits to master: http://git.io/u8eC9w
fcrepo4-client/master 97cafb3 Esmé Cowles: Read-only repository implementation
fcrepo4-client/master 6ccdd63 Andrew Woods: Merge pull request #8 from escowles/read-only...
* github-ff leaves
<pivotal-bot>Andrew Woods delivered "Implement read-only FedoraRepository" https://www.pivotaltracker.com/story/show/77109350
* travis-ci joins11:49
[travis-ci] fcrepo4-labs/fcrepo4-client#6 (master - 6ccdd63 : Andrew Woods): The build passed.
[travis-ci] Change view : https://github.com/fcrepo4-labs/fcrepo4-client/compare/a0e814467bfa...6ccdd63518c6
[travis-ci] Build details : http://travis-ci.org/fcrepo4-labs/fcrepo4-client/builds/33604058
* travis-ci leaves
* tecoripa joins12:02
* tecoripa leaves12:58
* tecoripa joins13:00
<pivotal-bot>Andrew Woods added comment: "Pending code review comments." https://www.pivotaltracker.com/story/show/7505329813:09
Andrew Woods rejected "Binary content resource impl" https://www.pivotaltracker.com/story/show/75053298
* dwilcox leaves13:35
* dwilcox joins13:39
* tecoripa leaves14:10
* gregjansen leaves14:13
* scossu leaves14:53
* dwilcox leaves15:20
* scossu joins15:24
* scossu leaves15:33
<pivotal-bot>Esme Cowles started "Binary content resource impl" https://www.pivotaltracker.com/story/show/7505329815:50
Esme Cowles added comment: "I've updated the PR to move the HTTP mechanics to a helper class and address your other comments: ""15:51
https://git�" https://www.pivotaltracker.com/story/show/75053298
Esme Cowles finished "Binary content resource impl" https://www.pivotaltracker.com/story/show/75053298
* scossu joins16:10
<pivotal-bot>Giulia HILL started "Acceptance test: many files using federation" https://www.pivotaltracker.com/story/show/7713127216:20
* scossu leaves16:27
<pivotal-bot>Andrew Woods added "Missing <security-role/> in auth-war" https://www.pivotaltracker.com/story/show/7765878816:37
* scossu joins16:58
* mohamed1 leaves17:06
* scossu leaves17:07
* scossu joins17:08
<pivotal-bot>Giulia HILL finished "Acceptance test: many files using federation" https://www.pivotaltracker.com/story/show/7713127217:34
* tecoripa joins17:42
* github-ff joins17:43
[fcrepo4-client] awoods pushed 1 new commit to master: http://git.io/ocwF2g
fcrepo4-client/master 842d1ee Esmé Cowles: Content impl., making some functionality shareable...
* github-ff leaves
<pivotal-bot>Andrew Woods added comment: "Resolved by: https://github.com/fcrepo4-labs/fcrepo4-client/commit/842d1ee2e4857c8c24541d0f8021bb3a184a8f26" https://www.pivotaltracker.com/story/show/75053298
Andrew Woods delivered "Binary content resource impl" https://www.pivotaltracker.com/story/show/75053298
* barmintor leaves
* github-ff joins17:44
[fcrepo4-client] awoods closed pull request #9: Content implementation, making triple-parsing functionality shareable (master...content-impl) http://git.io/yWivVw
* github-ff leaves
* tecoripa leaves17:45
* travis-ci joins17:49
[travis-ci] fcrepo4-labs/fcrepo4-client#8 (master - 842d1ee : Esmé Cowles): The build passed.
[travis-ci] Change view : https://github.com/fcrepo4-labs/fcrepo4-client/compare/6ccdd63518c6...842d1ee2e485
[travis-ci] Build details : http://travis-ci.org/fcrepo4-labs/fcrepo4-client/builds/33639236
* travis-ci leaves
<awoods>ksclarke: is surefire actually required for the PowerMock issue? We lost tracking of unit test coverage with that update: http://sonar.fcrepo.org/dashboard/index/378217:59
<ksclarke>hmm, yeah, but you can have surefire and failsafe (and configure each for a particular type of test)18:00
or if unit testing was lost, surefire should be able to do that... isn't surefire usually the unit test one and failsafe the integration test one?
awoods18:01
<awoods>ksclarke: yes, surefire = unit and failsafe = IT
* ksclarke goes to look at config
<awoods>ksclarke: are you suggesting we need to configure each of those plugins to capture the correct tests?
ksclarke: thanks for looking into it.18:02
<ksclarke>that's one way... but if it was unit testing that was lost, seems like surefire should be configurable to handle those
<awoods>ksclarke: I just noticed the dive in our coverage in the kernel-impl project after your PR: http://sonar.fcrepo.org/dashboard/index/org.fcrepo:fcrepo18:03
<ksclarke>awoods: all the unit tests are junit based?18:04
<awoods>ksclarke: yes
* scossu1 joins18:06
<ksclarke>awoods: when I run it I see 52 integration tests and (what looks like) 319 unit tests run
* ksclarke goes to look at dashboard
* scossu leaves18:07
* ff_logger leaves
<awoods>ksclarke: does this help: http://sonar.fcrepo.org/dashboard/index/3782?did=418:11
<ksclarke>dashboard shows a 72% to 5.5% drop?!
that makes me think it's more than just the kernel-impl... surely that can't contain 66.5% of the tests?18:12
I did update surefire and failsafe version numbers in that pr too
awoods: I'm not really familiar with sonar... does it call something specific beyond just mvn install?18:14
<awoods>ksclarke: jenkins runs the build and publishes the jacoco output to sonar18:15
ksclarke: jenkins build command is: mvn -Djacoco.outputDir=${WORKSPACE}/target clean install18:16
ksclarke: since your PR, the project unit test coverage dropped from 67.1% to 40.2%18:17
ksclarke: kernel-impl dropped from: 72.4% to 5.5%
ksclarke: I think all of the loss is in kernel-impl.18:18
<ksclarke>oh okay so that's just for the kernel-impl
but that's separate from integration tests right?
<awoods>ksclarke: yes, this is only unit tests
<ksclarke>so it's saying 5.5% of the unit tests still exist in kernel-impl?
<awoods>ksclarke: yes18:19
<ksclarke>weird
<awoods>ksclarke: and integration tests have remained unchanged.
<ksclarke>do you know the number of unit tests, does 319 seem like what 5.5% would be?
<awoods>ksclarke: no, I would expect 319 to be the full set18:20
<ksclarke>okay, so seems like unit tests are being run with build but not in the report then18:22
<awoods>ksclarke: agreed, something in the reporting got junked with the switch to surefire
<ksclarke>okay, looking into it
* scossu1 leaves18:32
<awoods>escowles: ping18:34
* Giulia leaves18:36
* Giulia joins
* ksclarke leaves18:38
* Giulia leaves19:31
<pivotal-bot>Andrew Woods unstarted "fcrepo4 doesn't build in windows" https://www.pivotaltracker.com/story/show/7707051619:52
Andrew Woods accepted "Implement read-only FedoraRepository" https://www.pivotaltracker.com/story/show/77109350
Andrew Woods accepted "Binary content resource impl" https://www.pivotaltracker.com/story/show/75053298
* marvilekke leaves21:04
* ksclarke joins21:20
* marvilekke joins21:21
<ksclarke>awoods: around?22:01
* github-ff joins22:30
[fcrepo4] ksclarke opened pull request #445: Possible fix for jacoco surefire problem (master...fix-surefire-reports) http://git.io/ZNzAHQ
* github-ff leaves
<ksclarke>^ that might fix the problem but am not running sonar locally so I'm not sure

Generated by Sualtam