Log of the #duraspace-ff channel on chat.freenode.net

Using timezone: Eastern Standard Time
* github-ff joins07:54
[fcrepo4] leenata opened pull request #88: Versions unit test (master...versions-unit-test) http://git.io/iXNX7A
* github-ff leaves
* kaarefc leaves09:08
* kaarefc joins09:49
* ksclarke joins09:52
* github-ff joins10:11
[fcrepo4] cbeer force-pushed versions-unit-test from 8bc8ce8 to 190979b: http://git.io/yuwt2g
fcrepo4/versions-unit-test 190979b Leenata Bankhele: JunitTest for versioning
* github-ff leaves
* github-ff joins10:14
[fcrepo4] cbeer force-pushed versions-unit-test from 2a8ede8 to d036938: http://git.io/yuwt2g
fcrepo4/versions-unit-test d036938 Leenata Bankhele: JunitTest for versioning
* github-ff leaves
* github-ff joins
[fcrepo4] cbeer pushed 1 new commit to master: http://git.io/6mFUxw
fcrepo4/master 1fef850 Leenata Bankhele: JunitTest for versioning
* github-ff leaves
* github-ff joins10:15
[fcrepo4] cbeer force-pushed versions-unit-test from d036938 to c6f0266: http://git.io/yuwt2g
fcrepo4/versions-unit-test c6f0266 Leenata Bankhele: JunitTest for versioning
* github-ff leaves
* fasseg leaves10:16
<leenata>hey hi chris10:17
i see..you just merged the junit test code with the master10:18
<cbeer>hi leenata: i squashed your pull request down to a single commit and cleaned up a trailing whitespace issue with it10:19
<leenata>i was looking for a review for that code first
oh ok
* eddies joins10:20
* eddies leaves
* eddies joins
<leenata>i was speaking with frank for a review since my understanding about versioning is little rt now. he was going to review it he said10:21
anyone is ok actually
<cbeer>leenata: yes, in general it look good to me. some of the mocking could probably be more strict, but some tests is better than no tests10:22
and the current impl of versioning is half-baked, soi'm not surprised
<leenata>i see.. then i can call this as the first version.. and keep on updating it10:26
<pivotal-bot_>Leenata finished "Add unit test coverage to FedoraVersions" https://www.pivotaltracker.com/story/show/5156671310:27
* kaarefc leaves
<bljenkins>Project fcrepo-fixity-corrupter build #183: SUCCESS in 1 min 14 sec: http://ci.fcrepo.org/jenkins/job/fcrepo-fixity-corrupter/183/10:29
* leenata leaves10:33
<bljenkins>Project fcrepo-fixity build #369: SUCCESS in 5 min 50 sec: http://ci.fcrepo.org/jenkins/job/fcrepo-fixity/369/10:34
Project fcrepo4 build #919: UNSTABLE in 16 min: http://ci.fcrepo.org/jenkins/job/fcrepo4/919/10:45
Chris Beer: JunitTest for versioning
<eddies>cbeer: to follow up on my comment to your gist. given that /dev/random is blocking there's a reasonable likelihood that there's a not-insignificant hit over using urandom10:53
but i'd feel better with numbers to back it up before we enshrine the use of urandom as a best practice10:54
<cbeer>eddies: gist? hm?10:58
<eddies>https://gist.github.com/cbeer/1400e40420006e2841cc
<cbeer>ok. i'm running some tests with a larger cluster now10:59
but then i can give that a go
<pivotal-bot_>Chris Beer edited "Document our use of sparql update to update object properties" https://www.pivotaltracker.com/story/show/5156610311:46
* nbanks joins12:14
<pivotal-bot_>Chris Beer delivered "Add test coverage for JcrRdfTools" https://www.pivotaltracker.com/story/show/5156586712:33
Chris Beer delivered "Add unit test coverage to FedoraVersions" https://www.pivotaltracker.com/story/show/5156671312:42
Chris Beer edited "Add reflection util to Testhelper for setting fields which lack a setter method" https://www.pivotaltracker.com/story/show/52055161
Chris Beer delivered "Add configuration without indexing and fSyncMode="default" for max ingest performance" https://www.pivotaltracker.com/story/show/51963457
* nbanks leaves13:01
* github-ff joins15:59
[fcrepo4] cbeer force-pushed reflection-test-helper from 08f991e to bfa6cbf: http://git.io/BbVgWw
fcrepo4/reflection-test-helper bfa6cbf fasseg: Removed setters that were only used in tests, added Testhelper mathod to set fields via reflection and changed the tests to use the new method
* github-ff leaves
* github-ff joins16:03
[fcrepo4] cbeer force-pushed reflection-test-helper from bfa6cbf to 8f432df: http://git.io/BbVgWw
fcrepo4/reflection-test-helper 8f432df fasseg: Removed setters that were only used in tests, added Testhelper mathod to set fields via reflection and changed the tests to use the new method
* github-ff leaves
* github-ff joins16:04
[fcrepo4] cbeer merged reflection-test-helper into master: http://git.io/9zdhGA
* github-ff leaves
<pivotal-bot_>Chris Beer delivered "Add reflection util to Testhelper for setting fields which lack a setter method" https://www.pivotaltracker.com/story/show/5205516116:05
* github-ff joins
[fcrepo4] cbeer deleted reflection-test-helper at 8f432df: http://git.io/x6vIsw
* github-ff leaves
* github-ff joins16:07
[fcrepo4] cbeer deleted versions-unit-test at c6f0266: http://git.io/Sj5heA
* github-ff leaves
* travis-ci joins16:14
[travis-ci] futures/fcrepo4#803 (master - 8f432df : fasseg): The build has errored.
[travis-ci] Change view : https://github.com/futures/fcrepo4/compare/1fef8505f91e...8f432df2cfdd
[travis-ci] Build details : http://travis-ci.org/futures/fcrepo4/builds/8517393
* travis-ci leaves
* github-ff joins16:22
[fcrepo4] cbeer pushed 1 new commit to master: http://git.io/dCZdZA
fcrepo4/master b7ab7b0 Chris Beer: Remove unnecessary FedoraRepositoryImportTest and just rely on the FedoraImportTest instead
* github-ff leaves
<bljenkins>Yippie, build fixed!16:23
Project fcrepo4 build #920: FIXED in 24 min: http://ci.fcrepo.org/jenkins/job/fcrepo4/920/
Project fcrepo-fixity-corrupter build #184: SUCCESS in 2 min 52 sec: http://ci.fcrepo.org/jenkins/job/fcrepo-fixity-corrupter/184/16:28
* travis-ci joins16:41
[travis-ci] futures/fcrepo4#804 (master - b7ab7b0 : Chris Beer): The build passed.
[travis-ci] Change view : https://github.com/futures/fcrepo4/compare/8f432df2cfdd...b7ab7b057ba4
[travis-ci] Build details : http://travis-ci.org/futures/fcrepo4/builds/8517938
* travis-ci leaves
<bljenkins>Project fcrepo-fixity-corrupter build #185: SUCCESS in 1 min 27 sec: http://ci.fcrepo.org/jenkins/job/fcrepo-fixity-corrupter/185/16:50
<pivotal-bot_>Edwin Shin accepted "Create UUIDPathMinter that mints UUID identifiers but prefixes them with some artificial hierarchy to increase JCR ..." https://www.pivotaltracker.com/story/show/5235014317:22
Edwin Shin accepted "Add unit test coverage to FedoraVersions" https://www.pivotaltracker.com/story/show/51566713
Edwin Shin delivered "Put checkstyle rules in a separate artifact" https://www.pivotaltracker.com/story/show/52378713
Edwin Shin accepted "Put checkstyle rules in a separate artifact" https://www.pivotaltracker.com/story/show/52378713
Edwin Shin delivered "Automate and validate source license headers" https://www.pivotaltracker.com/story/show/52418915
Edwin Shin accepted "Automate and validate source license headers" https://www.pivotaltracker.com/story/show/52418915
Edwin Shin added comment: "Some issues to be aware of: metrics 3.0 is still Jersey 1.x (worst case, exclude the metrics-jersey dependenc..." https://www.pivotaltracker.com/story/show/5220082317:57
Edwin Shin added comment: "For Jersey 1.x to 2.0 migration, see: https://jersey.java.net/documentation/latest/migration.html" https://www.pivotaltracker.com/story/show/5220082317:58
Edwin Shin added comment: "org.fcrepo.session.InjectableSession is certainly going to need to be rethought per above" https://www.pivotaltracker.com/story/show/5220082318:01
Edwin Shin added comment: "And the test framework has changed: https://jersey.java.net/documentation/latest/user-guide.html#test-framework" https://www.pivotaltracker.com/story/show/52200823
* ksclarke leaves18:20
<pivotal-bot_>Edwin Shin accepted "Add test coverage for JcrRdfTools" https://www.pivotaltracker.com/story/show/5156586718:52
<cbeer>eddies: i'm trying to update to the ISPN 5.3.0.Final and get this enforcer error:19:18
https://gist.github.com/cbeer/113f01f1de0c73ba64ff
<eddies>sec19:19
well, for the "right" fix, it would be nice if upstream didn't have two different versions of leveldbjni. but for right now, i would 1) add an exclusion for org.fusesource.leveldbjni:leveldbjni to infinispan-cachestore-leveldb in fcrepo-jcr19:23
and 2) add an explicit dependency in fcrepo-jcr on leveldbjni:1.719:24
(with comments in the pom explaining the dependency convergence issue)
<cbeer>ok, thanks19:25
<eddies>That assumes that leveldbjni:1.7 should work and that leveldbjni:1.5 isn't being used on all those platform-specific transitive dependencies for a reason. I'd try 1.7 and if things blow up, change the explicit dependency to 1.719:26
ack. 1.5 i meant
cbeer: did you get a chance to try that urandom property to see if it made a difference?19:28
<cbeer>haven't yet, no
spent forever rebasing fasseg's PR
<eddies>(it's not really a high priority, i'm just curious how much an effect it has)
which PR?19:29
<cbeer>the test helper reflection thing
<eddies>incidentally, that was a pretty amazing difference between oldconfig and newconfig
<cbeer>newconfig has several changes in it (i think i said what they were in the PR, but one of them was leveldb.. and the other escapes me)19:30
<eddies>i assumed it was mostly leveldb vs file store, though, rather than hierarchy, given that even at the very beginning of the two runs, oldconfig had a pretty low objects-per-second rate (so it couldn't just be flat vs hierarchical)
<cbeer>yes, and then the long-running performance improvement is the hierarchy change19:32
<eddies>right
<cbeer>seemed like it leveled off nicely
<eddies>i only skimmed your PR, but you're basically breaking up the UUID into path segments to make hierarchy, right?19:33
<cbeer>pretty much. i left it pretty configurable so we can do some testing and tune it later, but essentially we take the first N characters, split it into Y chunks, join them with the path separator, and append the original UUID as the leaf node19:34
so: 12345678-90abcd-efghijk => 12/34/56/78/12345678-90abcd-efghijk19:35
* github-ff joins
[fcrepo4] cbeer pushed 1 new commit to master: http://git.io/tcXeIQ
fcrepo4/master f92e907 Chris Beer: bump to ISPN 5.3.0.Final
* github-ff leaves
<eddies>ok. by-the-by, i made a local branch to see how messy upgrading to jersey 2.0 would be (which is what prompted my new comments to the tracker ticket)19:36
while it looks far too involved to squeeze in before OR
i think it should be a pretty high-priority item post-alpha. it changes enough things (and should simplify our ITs) that the longer we go on 1.x, the more painful the migration will be19:37
<cbeer>sounds good. it sounded like injectable sessions will have to be re-redone?
<eddies>yeah. that's the thing that had me stumped. mostly because i'm just unfamiliar w/ the current injectable sessions19:38
so i didn't know how to refactor that
<cbeer>magic. something about the proxy objects jersey actually uses to evaluate requests19:39
<eddies>i really like that our test rig for ITs should get simpler. fewer grizzly dependencies and we can use the standard jax-rs 2.0 client api instead of httpclient
and the jax-rs 2.0 client api should make all the java-based clients to fcrepo4 more straightforward too (and there's nothing to stop new services from using that api today, anyway)19:40
i also saw that jersey 2.0 has an optional library for freemarker integration if we really hate velocity and want to switch out ;-)19:42
i know how much you've come to love velocity
<cbeer>i don't remember much of our early freemarker stuff
i don't remember if it was because of trauma or not19:43
<eddies>oh i only remember stringtemplate (i thought ajs6f tried that one)
at least i think it was stringtemplate19:44
* bljenkins leaves
<eddies>in your copious free time, if you have a chance to try out that intellij plugin that lets you use the eclipse formatter settings, please let me know if/how it works19:45
* bljenkins joins19:46
<eddies>i'm thinking of a) moving those eclipse files to fcrepo-build-tools and b) updating our wiki docs and if we don't have to generate (and keep in sync) separate intellij files, then just bless the plugin and say to have at it
<cbeer>sounds good. i'll take a look soon. probably tomorrow. certainly before OR.19:47
<eddies>danke
* travis-ci joins20:00
[travis-ci] futures/fcrepo4#805 (master - f92e907 : Chris Beer): The build passed.
[travis-ci] Change view : https://github.com/futures/fcrepo4/compare/b7ab7b057ba4...f92e90729158
[travis-ci] Build details : http://travis-ci.org/futures/fcrepo4/builds/8523416
* travis-ci leaves
<bljenkins>Project fcrepo-fixity-corrupter build #186: SUCCESS in 2 min 6 sec: http://ci.fcrepo.org/jenkins/job/fcrepo-fixity-corrupter/186/20:07
* ksclarke joins21:14
* eddies leaves21:30
* eddies joins21:59
* eddies leaves
* eddies joins